fix: declare optional peer types (#606)

cyphercodes · antfu · web-flow · commit cc05acdf2397 · 2026-06-24T11:39:46.000+09:00
* fix: declare bundler type imports as optional peers

* fix: satisfy optional peer dependency checks

---------

Co-authored-by: cyphercodes &lt;cyphercodes@users.noreply.github.com&gt;
Co-authored-by: Anthony Fu &lt;github@antfu.me&gt;
diff --git a/package.json b/package.json
@@ -46,6 +46,46 @@
     "test": "nr test:build && vitest run",
     "test:build": "jiti scripts/buildFixtures.ts"
   },
+  "peerDependencies": {
+    "@farmfe/core": "*",
+    "@rspack/core": "*",
+    "bun-types-no-globals": "*",
+    "esbuild": "*",
+    "rolldown": "*",
+    "rollup": "*",
+    "unloader": "*",
+    "vite": "*",
+    "webpack": "*"
+  },
+  "peerDependenciesMeta": {
+    "@farmfe/core": {
+      "optional": true
+    },
+    "@rspack/core": {
+      "optional": true
+    },
+    "bun-types-no-globals": {
+      "optional": true
+    },
+    "esbuild": {
+      "optional": true
+    },
+    "rolldown": {
+      "optional": true
+    },
+    "rollup": {
+      "optional": true
+    },
+    "unloader": {
+      "optional": true
+    },
+    "vite": {
+      "optional": true
+    },
+    "webpack": {
+      "optional": true
+    }
+  },
   "dependencies": {
     "@jridgewell/remapping": "catalog:prod",
     "picomatch": "catalog:prod",
@@ -64,8 +104,8 @@
     "@typescript/native-preview": "catalog:dev",
     "ansis": "catalog:dev",
     "bumpp": "catalog:dev",
-    "bun-types-no-globals": "catalog:dev",
-    "esbuild": "catalog:dev",
+    "bun-types-no-globals": "catalog:peer",
+    "esbuild": "catalog:peer",
     "eslint": "catalog:dev",
     "eslint-plugin-format": "catalog:dev",
     "jiti": "catalog:dev",
@@ -86,7 +126,7 @@
     "webpack-cli": "catalog:test"
   },
   "resolutions": {
-    "esbuild": "catalog:dev"
+    "esbuild": "catalog:peer"
   },
   "simple-git-hooks": {
     "pre-commit": "pnpm i --frozen-lockfile --ignore-scripts --offline && pnpm exec lint-staged"
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/pnpm-workspace.yaml b/pnpm-workspace.yaml
@@ -20,8 +20,6 @@ catalogs:
     '@typescript/native-preview': 7.0.0-dev.20260508.1
     ansis: ^4.3.1
     bumpp: ^11.1.0
-    bun-types-no-globals: ^1.3.11
-    esbuild: ^0.28.1
     eslint: ^10.5.0
     eslint-plugin-format: ^2.0.1
     jiti: ^2.7.0
@@ -52,6 +50,8 @@ catalogs:
   peer:
     '@farmfe/core': ^1.7.11
     '@rspack/core': ^2.0.8
+    bun-types-no-globals: ^1.3.11
+    esbuild: ^0.28.1
     rolldown: ^1.1.2
     rollup: ^4.62.2
     unloader: ^0.9.0
diff --git a/tsdown.config.ts b/tsdown.config.ts
@@ -21,6 +21,7 @@ export default defineConfig({
   },
   unused: {
     level: 'error',
+    ignore: ['bun-types-no-globals'],
   },
   exports: true,
   publint: 'ci-only',
