Skip to content

feat(profiling) re-enable allocation profiling with JIT for PHP 8.4.7#3277

Merged
realFlowControl merged 2 commits into
masterfrom
florian/re-enable-allocation-profiling-with-jit
May 28, 2025
Merged

feat(profiling) re-enable allocation profiling with JIT for PHP 8.4.7#3277
realFlowControl merged 2 commits into
masterfrom
florian/re-enable-allocation-profiling-with-jit

Conversation

@realFlowControl

@realFlowControl realFlowControl commented May 28, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Description

With #3199 we've disable allocation profiling when an active JIT was detected on PHP 8.4. The upstream fix landed in PHP 8.4.7 and was confirmed to fix the issue, so we can allow allocation profiling even when an active JIT is detected on PHP >= 8.4.7

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@realFlowControl realFlowControl requested a review from a team as a code owner May 28, 2025 07:05
@github-actions github-actions Bot added profiling Relates to the Continuous Profiler tracing labels May 28, 2025
@codecov-commenter

codecov-commenter commented May 28, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.21%. Comparing base (0409a78) to head (8e8836d).
Report is 28 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3277      +/-   ##
============================================
+ Coverage     76.32%   79.21%   +2.88%     
  Complexity     2967     2967              
============================================
  Files           146      119      -27     
  Lines         16130    11681    -4449     
  Branches       1110        0    -1110     
============================================
- Hits          12312     9253    -3059     
+ Misses         3241     2428     -813     
+ Partials        577        0     -577
Flag Coverage Δ
appsec-extension ?
tracer-php 79.21% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 28 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0409a78...8e8836d. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@realFlowControl realFlowControl force-pushed the florian/re-enable-allocation-profiling-with-jit branch from 934b2b4 to 727f4fa Compare May 28, 2025 07:14
@pr-commenter

pr-commenter Bot commented May 28, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmarks [ profiler ]

Benchmark execution time: 2025-05-28 10:58:41

Comparing candidate commit 8e8836d in PR branch florian/re-enable-allocation-profiling-with-jit with baseline commit 0409a78 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 27 metrics, 9 unstable metrics.

bwoebi
bwoebi reviewed May 28, 2025
View reviewed changes
Comment thread profiling/src/allocation/allocation_ge84.rs Outdated
bwoebi
bwoebi approved these changes May 28, 2025
View reviewed changes

@bwoebi bwoebi left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now :-)

@realFlowControl realFlowControl enabled auto-merge (squash) May 28, 2025 11:07
@realFlowControl realFlowControl merged commit e06d45d into master May 28, 2025
710 of 739 checks passed
@realFlowControl realFlowControl deleted the florian/re-enable-allocation-profiling-with-jit branch May 28, 2025 11:29
@github-actions github-actions Bot added this to the 1.10.0 milestone May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bwoebi bwoebi bwoebi approved these changes

Assignees

No one assigned

Labels

profiling Relates to the Continuous Profiler

Projects

None yet

Milestone

1.10.0

Development

Successfully merging this pull request may close these issues.

3 participants

@realFlowControl @codecov-commenter @bwoebi