Fix legacy nausea effect intensity on 1.21.5+ clients#4964
Merged
Conversation
Set the 1.21.5 mob effect blend flag for translated nausea effects. Nausea gained explicit blend timing in 1.21.5, and packets without the blend flag cause modern clients to skip the transition and render the effect at full strength immediately. Preserve the existing mob effect flags and only add the blend flag for nausea.
kennytv
requested changes
Jun 7, 2026
Target the nausea effect (id 8) instead of id 9. :)
Contributor
Author
|
Ah, that's my bad. Before narrowing the fix down to just changing nausea, the AI previously incorrectly applied this to all effects. So, it looks like when I was verifying this build, I left that old version in my testing environment by accident, so as far as I knew, it "worked". I've updated the id to properly target nausea AND tested with the actual proper jar this time. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Sets the mob effect blend flag for nausea when translating
UPDATE_MOB_EFFECTfrom 1.21.4 to 1.21.5.Why
Nausea has explicit blend timing in 1.21.5. Without the blend flag, modern clients skip the transition and short/low-intensity nausea effects can appear at full strength immediately.
This preserves all existing mob effect flags and only adds the blend flag for nausea.
Testing
AI was used to help investigate the issue and prepare the patch. The behavior was reproduced and the resulting change was manually tested.