Skip to content

feat(app): improve titlebar tab layout #33914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Brendonovich merged 4 commits into from
Jun 25, 2026
Merged

feat(app): improve titlebar tab layout #33914

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dc5c27c
stuff
Brendonovich Jun 25, 2026
f7bdc21
test(app): align tab width regression threshold
Brendonovich Jun 25, 2026
a7ca10c
delete regression e2e
Brendonovich Jun 25, 2026
e336527
fix(app): keep tab close action clear of links
Brendonovich Jun 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test(app): align tab width regression threshold
  • Loading branch information
@Brendonovich
Brendonovich committed Jun 25, 2026
commit f7bdc21afd0b55c751c4d82a1e0210fe1592f904
99 changes: 82 additions & 17 deletions packages/app/e2e/regression/tab-width.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,20 +2,47 @@ import { expect, test, type Page, type Route } from "@playwright/test"
import { base64Encode } from "@opencode-ai/core/util/encode"

const server = "http://127.0.0.1:4096"
const sessionA = { id: "ses_a", slug: "ses_a", projectID: "proj_a", directory: "/repo/a", title: "Session A", version: "dev", time: { created: 1, updated: 1 } }
const sessionB = { id: "ses_b", slug: "ses_b", projectID: "proj_b", directory: "/repo/b", title: "Session B", version: "dev", time: { created: 2, updated: 2 } }
const sessionC = { id: "ses_c", slug: "ses_c", projectID: "proj_c", directory: "/repo/c", title: "Session C", version: "dev", time: { created: 3, updated: 3 } }
const sessionA = {
id: "ses_a",
slug: "ses_a",
projectID: "proj_a",
directory: "/repo/a",
title: "Session A",
version: "dev",
time: { created: 1, updated: 1 },
}
const sessionB = {
id: "ses_b",
slug: "ses_b",
projectID: "proj_b",
directory: "/repo/b",
title: "Session B",
version: "dev",
time: { created: 2, updated: 2 },
}
const sessionC = {
id: "ses_c",
slug: "ses_c",
projectID: "proj_c",
directory: "/repo/c",
title: "Session C",
version: "dev",
time: { created: 3, updated: 3 },
}

test("tabs shrink from their preferred width before scrolling", async ({ page }) => {
await mockServers(page)
await page.addInitScript(
({ server, sessionA, sessionB, sessionC }) => {
localStorage.setItem("settings.v3", JSON.stringify({ general: { newLayoutDesigns: true } }))
localStorage.setItem("opencode.global.dat:tabs", JSON.stringify([
{ type: "session", server, sessionId: sessionA.id },
{ type: "session", server, sessionId: sessionB.id },
{ type: "session", server, sessionId: sessionC.id },
]))
localStorage.setItem(
"opencode.global.dat:tabs",
JSON.stringify([
{ type: "session", server, sessionId: sessionA.id },
{ type: "session", server, sessionId: sessionB.id },
{ type: "session", server, sessionId: sessionC.id },
]),
)
},
{ server, sessionA, sessionB, sessionC },
)
Expand All @@ -42,20 +69,30 @@ test("tabs shrink from their preferred width before scrolling", async ({ page })
expect(strip!.width).toBeCloseTo(list!.width, 0)

await page.setViewportSize({ width: 700, height: 720 })
await expect.poll(() => tabSlots.nth(0).evaluate((element) => element.getBoundingClientRect().width)).toBeLessThan(224)
await expect
.poll(() => tabSlots.nth(0).evaluate((element) => element.getBoundingClientRect().width))
.toBeLessThan(224)
expect(await tabSlots.nth(0).evaluate((element) => element.getBoundingClientRect().width)).toBeGreaterThan(96)
expect(
await page.locator('[data-slot="titlebar-tabs-scroll"]').evaluate((element) => element.scrollWidth <= element.clientWidth),
await page
.locator('[data-slot="titlebar-tabs-scroll"]')
.evaluate((element) => element.scrollWidth <= element.clientWidth),
).toBe(true)

await page.setViewportSize({ width: 420, height: 720 })
await expect.poll(() => tabSlots.nth(0).evaluate((element) => element.getBoundingClientRect().width)).toBeCloseTo(96, 0)
await page.setViewportSize({ width: 220, height: 720 })
await expect
.poll(() => tabSlots.nth(0).evaluate((element) => element.getBoundingClientRect().width))
.toBeCloseTo(28, 0)
expect(
await page.locator('[data-slot="titlebar-tabs-scroll"]').evaluate((element) => element.scrollWidth > element.clientWidth),
await page
.locator('[data-slot="titlebar-tabs-scroll"]')
.evaluate((element) => element.scrollWidth > element.clientWidth),
).toBe(true)

await page.setViewportSize({ width: 1280, height: 720 })
await expect.poll(() => tabSlots.nth(0).evaluate((element) => element.getBoundingClientRect().width)).toBeCloseTo(224, 0)
await expect
.poll(() => tabSlots.nth(0).evaluate((element) => element.getBoundingClientRect().width))
.toBeCloseTo(224, 0)

const first = await tabSlots.nth(0).boundingBox()
const second = await tabSlots.nth(1).boundingBox()
Expand Down Expand Up @@ -129,17 +166,45 @@ async function mockServers(page: Page) {
return json(route, { all: [], connected: [], default: { providerID: "", modelID: "" } })
if (url.pathname === "/agent") return json(route, [{ name: "build", mode: "primary" }])
if (url.pathname === "/project" || url.pathname === "/project/current") {
return json(route, url.pathname === "/project" ? sessions.map((s) => ({ id: s.projectID, worktree: s.directory, vcs: "git", time: { created: 1, updated: 1 }, sandboxes: [] })) : { id: current.projectID, worktree: current.directory, vcs: "git", time: { created: 1, updated: 1 }, sandboxes: [] })
return json(
route,
url.pathname === "/project"
? sessions.map((s) => ({
id: s.projectID,
worktree: s.directory,
vcs: "git",
time: { created: 1, updated: 1 },
sandboxes: [],
}))
: {
id: current.projectID,
worktree: current.directory,
vcs: "git",
time: { created: 1, updated: 1 },
sandboxes: [],
},
)
}
if (url.pathname === "/path")
return json(route, { state: current.directory, config: current.directory, worktree: current.directory, directory: current.directory, home: current.directory })
return json(route, {
state: current.directory,
config: current.directory,
worktree: current.directory,
directory: current.directory,
home: current.directory,
})
if (url.pathname === "/vcs") return json(route, { branch: "main", default_branch: "main" })
return json(route, {})
})
}

function json(route: Route, body: unknown, status = 200) {
return route.fulfill({ status, contentType: "application/json", headers: { "access-control-allow-origin": "*" }, body: JSON.stringify(body) })
return route.fulfill({
status,
contentType: "application/json",
headers: { "access-control-allow-origin": "*" },
body: JSON.stringify(body),
})
}

function sse(route: Route) {
Expand Down
Loading