Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
88.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

It seems that the java.beans.PropertyDescriptor API will always return the getter method on the ModelDriven interface rather than the Action (I didn't actually realise this when I wrote this feature). This means it doesn't matter if getModel on the actual Action class is annotated or not, it will only ever check the interface method.

To be honest, I don't mind this behaviour - what if we just exempt all model driven Actions from the annotation requirement? The @StrutsParameter requirement was designed to protect against random getters/setters on the Action class from being injected. But if an Action is using a dedicated model object (and the Action class is indeed not on the root of the ValueStack) it is already much safer.

Here is my alternative solution for your consideration: f67f593

I'm fine either way, my PR is just a starting point for discussion. Feel free to open PR and we can discuss further.

I've created #1072 which exempts ModelDriven Actions from the annotation requirement entirely - I've also retained your other changes, including the additional debug logging, with some minor adjustments