WW-5472 Removes Struts Sitemesh plugin#1077
Merged
lukaszlenart merged 1 commit intoOct 20, 2024
Merged
Conversation
cdf4478 to
ce71dab
Compare
|
sepe81
reviewed
Feb 13, 2025
| <meta name="author" content="The Apache Software Foundation"> | ||
|
|
||
| <title><decorator:title default="Struts2 Showcase"/></title> | ||
| <title><sitemesh:write property="title"/></title> |
Contributor
There was a problem hiding this comment.
@lukaszlenart Don't we need a taglib replacement on L:52?
IntelliJ warns Namespace 'sitemesh' is not bound.
Member
Author
There was a problem hiding this comment.
Should be ok based on the doc
https://github.com/sitemesh/sitemesh3?tab=readme-ov-file#creating-a-decorator
Contributor
There was a problem hiding this comment.
Thank you for the clarification!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WW-5472
PR removes Struts Sitemesh plugin as the plugin uses Sitemesh 2 which isn't supported anymore. It also replaces Struts Sitemesh plugin integration in the Showcase app with pure Sitemesh 3 integration.
Depends on WW-5473Depends on #1078