Skip to content

WW-5501 Exclude malicious names#1156

Merged
lukaszlenart merged 2 commits into
release/struts-6-7-xfrom
feature/WW-5501-exclude
Dec 23, 2024
Merged

WW-5501 Exclude malicious names#1156
lukaszlenart merged 2 commits into
release/struts-6-7-xfrom
feature/WW-5501-exclude

Conversation

@lukaszlenart

@lukaszlenart lukaszlenart commented Dec 23, 2024

Copy link
Copy Markdown
Member

Hardening file upload logic

github-advanced-security[bot]
github-advanced-security AI found potential problems Dec 23, 2024
View reviewed changes
Comment thread core/src/main/java/org/apache/struts2/dispatcher/multipart/JakartaMultiPartRequest.java Fixed
Comment thread core/src/main/java/org/apache/struts2/dispatcher/multipart/JakartaMultiPartRequest.java Fixed
Comment thread core/src/main/java/org/apache/struts2/dispatcher/multipart/JakartaMultiPartRequest.java Fixed
Comment thread core/src/main/java/org/apache/struts2/dispatcher/multipart/JakartaStreamMultiPartRequest.java Fixed
Comment thread core/src/main/java/org/apache/struts2/dispatcher/multipart/JakartaStreamMultiPartRequest.java Fixed
@lukaszlenart lukaszlenart force-pushed the feature/WW-5501-exclude branch from c537d2c to 5237a99 Compare December 23, 2024 10:46
@lukaszlenart lukaszlenart force-pushed the feature/WW-5501-exclude branch from 5237a99 to 09993e3 Compare December 23, 2024 11:05
@sonarqubecloud

sonarqubecloud Bot commented Dec 23, 2024

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
22 Security Hotspots
42.2% Coverage on New Code (required ≥ 80%)
3.4% Duplication on New Code (required ≤ 3%)
E Reliability Rating on New Code (required ≥ A)
E Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

kusalk
kusalk approved these changes Dec 23, 2024
View reviewed changes
Comment thread core/src/main/java/org/apache/struts2/dispatcher/multipart/AbstractMultiPartRequest.java Outdated
@lukaszlenart lukaszlenart requested a review from kusalk December 23, 2024 13:13
@lukaszlenart lukaszlenart merged commit c8febc2 into release/struts-6-7-x Dec 23, 2024
@lukaszlenart lukaszlenart deleted the feature/WW-5501-exclude branch December 23, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kusalk kusalk kusalk approved these changes
@rgielen rgielen Awaiting requested review from rgielen
@aleksandr-m aleksandr-m Awaiting requested review from aleksandr-m
@yasserzamani yasserzamani Awaiting requested review from yasserzamani
@sdutry sdutry Awaiting requested review from sdutry

Assignees

No one assigned

Labels

Lazy Consensus

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lukaszlenart @kusalk @github-advanced-security