Skip to content

WW-5517 Fixes <s:debug/> to be compatible with allowlist capability#1187

Merged
lukaszlenart merged 2 commits into
mainfrom
fix/WW-5517-debug
Jan 21, 2025
Merged

WW-5517 Fixes <s:debug/> to be compatible with allowlist capability#1187
lukaszlenart merged 2 commits into
mainfrom
fix/WW-5517-debug

Conversation

@lukaszlenart

Copy link
Copy Markdown
Member

@lukaszlenart lukaszlenart marked this pull request as draft January 18, 2025 18:30
@lukaszlenart lukaszlenart force-pushed the fix/WW-5517-debug branch 5 times, most recently from 5b05621 to 940b0ea Compare January 18, 2025 20:40
@lukaszlenart lukaszlenart marked this pull request as ready for review January 18, 2025 21:04

@kusalk kusalk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! - doesn't look like the allowlist fixes are covered by any tests but given this is for debugging purposes it's not critical

Comment thread core/src/test/java/org/apache/struts2/views/jsp/ui/DebugTagTest.java Outdated
@lukaszlenart

Copy link
Copy Markdown
Member Author

LGTM! - doesn't look like the allowlist fixes are covered by any tests but given this is for debugging purposes it's not critical

You mean to check if a specific class has been added to allowlist after debugging?

@lukaszlenart

Copy link
Copy Markdown
Member Author

Done

@lukaszlenart lukaszlenart force-pushed the fix/WW-5517-debug branch 2 times, most recently from 43a8ce6 to edee6e3 Compare January 20, 2025 07:58
@sonarqubecloud

Copy link
Copy Markdown

@lukaszlenart lukaszlenart added this to the 7.0.1 milestone Jan 21, 2025

@kusalk kusalk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@lukaszlenart lukaszlenart merged commit 4e80f26 into main Jan 21, 2025
@lukaszlenart lukaszlenart deleted the fix/WW-5517-debug branch January 21, 2025 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants