WW-5504 Allows to use request instead of session attribute to store nonce#1352
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enables using request attributes instead of session attributes to store CSP nonce values for improved flexibility in nonce management.
Key changes:
- Added configuration option
struts.csp.nonce.sourceto specify whether nonce values are stored in session or request scope - Introduced new
CspNonceReaderinterface andStrutsCspNonceReaderimplementation to abstract nonce value retrieval - Modified
DefaultCspSettingsto support both session and request-based nonce generation
Reviewed Changes
Copilot reviewed 32 out of 32 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| core/src/main/java/org/apache/struts2/interceptor/csp/StrutsCspNonceReader.java | New implementation for reading nonce values from either session or request attributes |
| core/src/main/java/org/apache/struts2/interceptor/csp/DefaultCspSettings.java | Updated to support configurable nonce source and refactored nonce generation logic |
| core/src/main/java/org/apache/struts2/components/UIBean.java | Modified to use the new CspNonceReader interface instead of direct session access |
| core/src/main/resources/org/apache/struts2/default.properties | Added configuration property for nonce source selection |
| plugins/javatemplates/src/test/java/org/apache/struts2/views/java/simple/*.java | Updated test files to inject CspNonceReader dependencies |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
bca2c9b to
d557e8b
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WW-5504