WW-5444 Add HTML5 theme with comprehensive unit tests#1422
Merged
Conversation
sepe81
suggested changes
Nov 24, 2025
lukaszlenart
commented
Nov 24, 2025
2ccca73 to
04613ba
Compare
- Move 42 FreeMarker templates to core/src/main/resources/template/html5/ - Remove duplicate templates from showcase - Makes html5 theme available to all applications via struts2-core.jar - Enables unit testing in core module - Fix Html5Action import from XWork2 to Struts2 package - Add Apache license header to Html5Action Resolves WW-5444 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Add detailed implementation plan documenting the migration of html5 theme from showcase to core, including step-by-step instructions, verification procedures, and acceptance criteria. Related to WW-5444 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
…ables - Add testGenericHtml5() methods to 13 UI tag test classes - Create theme.properties with parent=simple configuration - Migrate all 32 HTML5 templates from deprecated 'parameters' to 'attributes' variable - Exclude DoubleSelect and UpDownSelect (not supported in HTML5 theme) - All 26 HTML5 theme tests passing (100% success rate) Components tested: Textfield, Textarea, Password, Checkbox, CheckboxList, Radio, Select, File, Hidden, Label, ComboBox, Reset, Submit 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Update CLAUDE.md with current project guidelines - Update test-runner agent documentation - Remove deprecated jakarta-migration-helper agent 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
…asses Add HTML5 theme tests to ActionErrorTagTest, ActionMessageTagTest, FieldErrorTagTest, AnchorTest, and FormTagTest. This completes Phase 1 of the HTML5 theme testing plan. Changes: - Add 24 new HTML5 theme unit tests across 5 test classes - Create 17 expected output files for HTML5 theme validation - Test coverage: action errors, action messages, field errors, anchors, and forms - All tests verify HTML5 clean markup without table-based layouts Coverage: 18 of 18 UI tag test classes now have HTML5 tests (100%) Tests passing: 24/24 HTML5 tests successful 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Create Html5TagExampleTest with 5 comprehensive integration tests - Add fielderror tag demonstration to html5/index.jsp - Validate HTML5 theme rendering, error display, and clean markup - All tests passing (5/5) with HtmlUnit and Jetty integration Tests validate: - Page load and HTTP status (200) - Action errors, messages, and field errors display - Clean semantic markup (ul lists, no table layouts) - Anchor tag rendering - Namespace isolation under /html5 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
04613ba to
66cf785
Compare
…mpress tag - Create CompressModel.java to enable <@s.compress> in FreeMarker templates - Register compress tag in StrutsModels.java for @s namespace access - Migrate all 29 HTML5 theme templates from <#compress> to <@s.compress> - Maintain identical compression behavior (uses same >\\s+< regex pattern) - All 153 HTML5 theme unit tests pass without modification This change leverages the new configurable Compress component (WW-5256) which provides devMode awareness and security protections while maintaining the same whitespace removal behavior as FreeMarker's built-in directive. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
be5d83b to
e5f884a
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the HTML5 theme to Struts core framework and implements comprehensive unit testing:
core/src/main/resources/template/html5/attributesinstead of deprecatedparametersvariabletheme.propertieswith parent theme configurationChanges
Theme Implementation
theme.propertieswithparent=simpleconfigurationparameterstoattributesvariableUnit Tests
Added
testGenericHtml5()andtestGenericHtml5_clearTagStateSet()methods to:Excluded: DoubleSelect and UpDownSelect (not supported in HTML5 theme)
Documentation
Test Results
Closes WW-5444
🤖 Generated with Claude Code