WW-5594 Fix convention plugin wildcard exclusion pattern for root packages#1468
Merged
Merged
Conversation
…atterns The exclusion pattern "org.apache.struts2.*" was not properly excluding classes directly in the root package (like XWorkTestCase) because: 1. PackageBasedActionConfigBuilder extracts package names using substringBeforeLast(className, ".") which produces "org.apache.struts2" (no trailing dot) 2. The wildcard pattern requires a literal "." before "*" 3. Result: Pattern doesn't match root package classes Fix: Enhanced checkExcludePackages() to automatically handle patterns ending with ".*" by also checking if the package name equals the base pattern (without ".*"). Now "org.apache.struts2.*" properly excludes both: - Classes in root package: org.apache.struts2.XWorkTestCase - Classes in subpackages: org.apache.struts2.dispatcher.SomeClass Closes [WW-5594](https://issues.apache.org/jira/browse/WW-5594) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
|
kusalk
approved these changes
Dec 14, 2025
jogep
approved these changes
Dec 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes WW-5594 - Convention plugin exclusion pattern
org.apache.struts2.*was not properly excluding classes directly in the root package.Problem
The exclusion pattern
org.apache.struts2.*was not excluding classes likeXWorkTestCasedirectly in theorg.apache.struts2package because:PackageBasedActionConfigBuilderextracts package names usingsubstringBeforeLast(className, ".")which producesorg.apache.struts2(no trailing dot).before*Solution
Enhanced
checkExcludePackages()to automatically handle patterns ending with.*by also checking if the package name equals the base pattern (without.*).Now
org.apache.struts2.*properly excludes both:org.apache.struts2.XWorkTestCaseorg.apache.struts2.dispatcher.SomeClassBenefits
.*patterns now work correctlyTest plan
WildcardHelperTest.testWW5594_WildcardPatternRequiresTrailingDot()- documents WildcardHelper behaviorWildcardHelperTest.testWW5594_ExactPackagePatternMatchesPackageName()- documents exact pattern matchingPackageBasedActionConfigBuilderTest.testWW5594_RootPackageExclusion()- verifies the fix🤖 Generated with Claude Code