fix(website): use correct image source#1115
Merged
Merged
Conversation
B4nan
approved these changes
Mar 24, 2025
Member
|
dang, this should have been |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The image sources as they are, are fetching the images from the root, i.e. https://crawlee.dev . Instead, we want them to fetch from crawlee python. There is namely one image that is different and has "Javascript" written on it (see if you can find it), but it should be "Python". The rest of the images are the same between js and py, so it doesn't matter as much.
I tested it with
yarn startfor the dev mode, andnpx docusaurus build+npx docusaurus servefor a production-like build and in both cases the images are fetched correctly