fix: call failed_request_handler for SessionError when session rotation count exceeds maximum#1147
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/crawlee/crawlers/_basic/_basic_crawler.py:1176
- Ensure that the _handle_failed_request method fully captures any necessary error logging and tracking, as the previous direct call to the error tracker has been removed.
await self._handle_failed_request(context, session_error)
janbuchar
approved these changes
Apr 23, 2025
Mantisus
added a commit
to Mantisus/crawlee-python
that referenced
this pull request
Apr 24, 2025
…tation count exceeds maximum (apify#1147) - Call `failed_request_handler` for `SessionError` when session rotation count exceeds maximum
Mantisus
added a commit
to Mantisus/crawlee-python
that referenced
this pull request
Apr 24, 2025
…tation count exceeds maximum (apify#1147) - Call `failed_request_handler` for `SessionError` when session rotation count exceeds maximum
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
failed_request_handlerforSessionErrorwhen session rotation count exceeds maximum