Skip to content

fix: handling of relative URLs in add_requests#213

Merged
janbuchar merged 2 commits into
masterfrom
fix-add-requests-relative-urls
Jun 24, 2024
Merged

fix: handling of relative URLs in add_requests#213
janbuchar merged 2 commits into
masterfrom
fix-add-requests-relative-urls

Conversation

@janbuchar

Copy link
Copy Markdown
Collaborator

@janbuchar janbuchar added the t-tooling Issues with this label are in the ownership of the tooling team. label Jun 24, 2024
@janbuchar janbuchar requested a review from vdusek June 24, 2024 11:08
@github-actions github-actions Bot added this to the 92nd sprint - Tooling team milestone Jun 24, 2024
@github-actions github-actions Bot added the tested Temporary label used only programatically for some analytics. label Jun 24, 2024

@vdusek vdusek left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Could you please just add the change description to the changelog? Thanks.

@janbuchar

Copy link
Copy Markdown
Collaborator Author

Good job! Could you please just add the change description to the changelog? Thanks.

I mean, sure. But is there any chance we could automate that? It's pretty much the reason why we bother with conventional commits after all.

@vdusek

vdusek commented Jun 24, 2024

Copy link
Copy Markdown
Collaborator

I mean, sure. But is there any chance we could automate that? It's pretty much the reason why we bother with conventional commits after all.

Completely agree; automating this would be great. One of the first issues opened addresses this #18. Hopefully, it can be done right after the public launch.

@janbuchar janbuchar merged commit 8aa8c57 into master Jun 24, 2024
@janbuchar janbuchar deleted the fix-add-requests-relative-urls branch June 24, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enqueue links does not process all links on the page Fix EnqueueStrategy issue with RESPX in test_enqueue_links

2 participants