feat: add abort_on_error property#731
Merged
Merged
Conversation
janbuchar
requested changes
Nov 25, 2024
janbuchar
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, but the naming in tests could be improved
|
|
||
|
|
||
| @pytest.mark.parametrize( | ||
| ('n_requests', 'n_error_request', 'e_starts', 'e_finished'), |
Collaborator
There was a problem hiding this comment.
Could you rename these so that it's more obvious what they do? The seconds one is the most hard one to understand for me.
Member
|
Sounds good to me, I liked the |
janbuchar
approved these changes
Nov 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
abort_on_erroraborting execution when an error occursIssues
fail_fastflag for automatic run failures on errors #704Testing
Checklist