fix: Fix incorrect use of desired concurrency ratio#780
Merged
Conversation
vdusek
approved these changes
Dec 4, 2024
vdusek
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, just one typo & probably wrong test function declaration.
Co-authored-by: Vlada Dusek <v.dusek96@gmail.com>
vdusek
reviewed
Dec 4, 2024
vdusek
left a comment
Collaborator
There was a problem hiding this comment.
Let's wait for Honza's approve as well, since he implemented this and he knows the code well.
Collaborator
Author
I was considering that. That issue is not well described so in the end I guessed, that it might be other problem. Might be solved by this, but I doubt it and without further details I will not be able to confirm it with certainty. |
janbuchar
approved these changes
Dec 5, 2024
Closed
Mantisus
pushed a commit
to Mantisus/crawlee-python
that referenced
this pull request
Dec 10, 2024
### Description Concurrency ratio was not correctly used in Python version of autoscaled pool. Align it with the Javascript implementation of autoscaled pool. Add test. ### Issues - Closes: apify#759 --------- Co-authored-by: Vlada Dusek <v.dusek96@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Concurrency ratio was not correctly used in Python version of autoscaled pool. Align it with the Javascript implementation of autoscaled pool.
Add test.
Issues