fix: Make result of RequestList.is_empty independent of fetch_next_request calls#876
Merged
Conversation
Pijukatel
reviewed
Jan 7, 2025
vdusek
reviewed
Jan 7, 2025
vdusek
left a comment
Collaborator
There was a problem hiding this comment.
Would it be possible to add a test case that covers the issue from the SDK?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old version of
RequestListonly updated the_is_emptyflag onfetch_next_requestcalls, which was not enough. This PR updates it so that theis_emptymethod also tries to dequeue a request from the iterator before returning a result.