Skip to content

feat: add block_requests helper for PlaywrightCrawler#919

Merged
janbuchar merged 8 commits into
apify:masterfrom
Mantisus:playwright-block-images
Jan 23, 2025
Merged

feat: add block_requests helper for PlaywrightCrawler#919
janbuchar merged 8 commits into
apify:masterfrom
Mantisus:playwright-block-images

Conversation

@Mantisus

@Mantisus Mantisus commented Jan 20, 2025

Copy link
Copy Markdown
Collaborator

Description

  • Add block_requests helper for PlaywrightCrawler
  • Add example for docs

Issues

@Mantisus Mantisus self-assigned this Jan 20, 2025
@janbuchar janbuchar requested review from Pijukatel and vdusek January 20, 2025 11:13
@vdusek vdusek added this to the 106th sprint - Tooling team milestone Jan 21, 2025
Comment thread src/crawlee/crawlers/_playwright/_utils.py Outdated
@Mantisus Mantisus requested a review from Pijukatel January 22, 2025 07:27

@vdusek vdusek left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments regarding the docs. Otherwise LGTM.

Comment thread src/crawlee/crawlers/_playwright/_types.py Outdated
Comment thread src/crawlee/crawlers/_playwright/_types.py
Comment thread src/crawlee/crawlers/_playwright/_utils.py
Comment thread src/crawlee/crawlers/_playwright/_types.py
Comment thread docs/examples/playwright_crawler_with_block_requests.mdx Outdated
Comment thread docs/examples/code/playwright_block_requests.py Outdated
Comment thread docs/examples/playwright_crawler_with_block_requests.mdx
Mantisus and others added 4 commits January 22, 2025 12:31
Co-authored-by: Vlada Dusek <v.dusek96@gmail.com>
Co-authored-by: Vlada Dusek <v.dusek96@gmail.com>
Co-authored-by: Vlada Dusek <v.dusek96@gmail.com>
Comment thread src/crawlee/crawlers/_playwright/_types.py Outdated

@vdusek vdusek left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@janbuchar janbuchar merged commit 1030459 into apify:master Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Block images while using PlaywrightCrawler

5 participants