feat: Return handler upon decorator invocation#934
Merged
Conversation
Contributor
Author
Thanks for the quick response! 🙌 Of course; so I have two pages that are almost identical but one requires just a couple of actions more. I tried a couple of different options but in the end I just thought the cleanest would be to tag the same handler with 2 labels and just use an if statement like in the docs. So yes, my specific use case is indeed just for routing multiple labels to the same handler that require only a small deviation from the general logic! Thanks for merging this in! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, wrapping a handler with a decorator nullifies the function because it returns
Nonein the code. See the "None" popup over here:By having the router.handler function return the original input handler, we can now reuse the handler function again in other places as it's not set to
Noneanymore. This allows for invoking the original function even after applying the decorator and for adding multiple decorators to the same handler function. The latter for example allows for using the same handler function for multiple labels (a use case I ran into).Issues
Not applicable.
Testing
Checklist
Please let me know your thoughts! 🙌