fix: fix CurlImpersonateHttpClient cookies handler#946
Merged
Conversation
Collaborator
|
Could you add a test please? |
Collaborator
Author
Yeah sure, but I need that PR #947 for these tests 🙂 |
Collaborator
Author
|
Added tests |
vdusek
approved these changes
Feb 3, 2025
vdusek
left a comment
Collaborator
There was a problem hiding this comment.
One nit, otherwise LGTM.
Co-authored-by: Vlada Dusek <v.dusek96@gmail.com>
janbuchar
reviewed
Feb 4, 2025
janbuchar
left a comment
Collaborator
There was a problem hiding this comment.
I have some test-related nits, other than that, it looks good
Co-authored-by: Jan Buchar <Teyras@gmail.com>
janbuchar
reviewed
Feb 4, 2025
janbuchar
approved these changes
Feb 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
HttpxHttpClient.Issues