Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

• Do the proposed changes actually accomplish desired goals?
• Do the proposed changes follow the Astropy coding guidelines?
• Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
• Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
• Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
• Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
• Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
• Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
• At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

pre-commit.ci autofix

I think it makes sense to revert to unblock 7.1, especially as the fix for the problems uncovered does not seem trivial. But I'll let @saimn look before approving.

Thanks for your understanding. I will reopen the issue that the reverted PR closed.

FYI: this broke astroquery docs build astropy/astroquery#3326

More precisely, this triggered #17546 to break astroquery. What I see downstream for all the type annotation PRs is pure net negative.

@bsipocz - I think you are not commenting on the right PR - this one had nothing to do with typing. I mention it in part since I very much think that if typing is causing down-stream problems, those so keen to introduce it need to know about it and ensure it doesn't happen again.

Yes, I suppose that was a badly executed manual bisect as at first I only compared this one and the previous change, but I only checked that one in its backported version that ended up in 7.0.2.

The real breaking PR is the typing one mentioned in my previous comment, rolling back those ConfigItem generator types fixes the docs build...

And I cannot emphasize it enough how frustrating all this typing stuff is, along with random ruff rules, it's not the first time it causes unexpected issues downstream forcing others to clean up the mess. (This particular sphinx one is something I can only workaround but not fix downstream)