Remove python 2 __future__ syntax#1864
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1864 +/- ##
==========================================
- Coverage 64.44% 64.37% -0.08%
==========================================
Files 200 200
Lines 16033 15998 -35
==========================================
- Hits 10333 10298 -35
Misses 5700 5700
Continue to review full report at Codecov.
|
ceb8
approved these changes
Oct 20, 2020
ceb8
left a comment
Member
There was a problem hiding this comment.
This looks good to me. Just need @bsipocz or @keflavich to take a last look at it and it should be ready to merge.
bsipocz
approved these changes
Oct 21, 2020
Member
|
Thank you @daisycodes! I totally agree that changing the prints the 2to3 way makes little sense, so thanks for not pushing those to the PR. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the use of
from __future__usages in the codebase. I'm using the2to3translator which comes with the python interpreter as a script. By default it uses a lot of fixers which made changes I wasn't sure is what we want. For example this linewas replaced with
And also calls to the
items()method of dictionaries were wrapped arounded thelist()function. While all these are valid code, I just don't see the point and felt like these will just increase code review time. What are your thoughts on these modifications and is there another approach to removing all python2 code in a sensible way?I'm not adding the closes section of this PR because I don't want the issue to be closed when this PR gets merged as it doesn't resolve the ticket completely.