Eso documentation cleanup#1972
Merged
Merged
Conversation
ceb8
approved these changes
Jan 30, 2022
Codecov Report
@@ Coverage Diff @@
## main #1972 +/- ##
==========================================
+ Coverage 62.95% 63.29% +0.34%
==========================================
Files 131 132 +1
Lines 17038 17256 +218
==========================================
+ Hits 10727 10923 +196
- Misses 6311 6333 +22
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
ceb8
approved these changes
Apr 27, 2022
Member
|
@bsipocz This should be ready to go now. |
bsipocz
approved these changes
Apr 27, 2022
bsipocz
left a comment
Member
There was a problem hiding this comment.
Looks good.
I left a few comments for some more minor cleanups, up to you whether you do them or not in this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.