Skip to content

Eso documentation cleanup#1972

Merged
ceb8 merged 3 commits into
astropy:mainfrom
tinuademargaret:eso-doc-cleanup
Apr 29, 2022
Merged

Eso documentation cleanup#1972
ceb8 merged 3 commits into
astropy:mainfrom
tinuademargaret:eso-doc-cleanup

Conversation

@tinuademargaret

Copy link
Copy Markdown
Contributor

No description provided.

@astropy-bot astropy-bot Bot added the eso label Feb 2, 2021
@tinuademargaret tinuademargaret added this to the v0.4.2 milestone Feb 2, 2021
@bsipocz bsipocz modified the milestones: v0.4.2, v0.4.3 May 15, 2021
@bsipocz bsipocz removed this from the v0.4.3 milestone Jul 7, 2021
@bsipocz bsipocz marked this pull request as draft February 19, 2022 03:45
@bsipocz bsipocz requested a review from ceb8 February 19, 2022 03:45
@ceb8 ceb8 force-pushed the eso-doc-cleanup branch from 6042464 to 86fecd1 Compare March 24, 2022 21:19
@ceb8 ceb8 added this to the v0.4.7 milestone Mar 24, 2022
@codecov

codecov Bot commented Apr 27, 2022

Copy link
Copy Markdown

Codecov Report

Merging #1972 (4519f73) into main (a03f301) will increase coverage by 0.34%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1972      +/-   ##
==========================================
+ Coverage   62.95%   63.29%   +0.34%     
==========================================
  Files         131      132       +1     
  Lines       17038    17256     +218     
==========================================
+ Hits        10727    10923     +196     
- Misses       6311     6333      +22     
Impacted Files Coverage Δ
astroquery/atomic/core.py 35.77% <0.00%> (-1.12%) ⬇️
astroquery/cadc/core.py 76.87% <0.00%> (-0.52%) ⬇️
astroquery/jplsbdb/core.py 78.61% <0.00%> (-0.09%) ⬇️
astroquery/esa/iso/core.py 64.58% <0.00%> (ø)
astroquery/esa/hsa/core.py 36.55% <0.00%> (ø)
astroquery/utils/commons.py 78.39% <0.00%> (+0.10%) ⬆️
astroquery/casda/core.py 93.01% <0.00%> (+2.61%) ⬆️
astroquery/heasarc/core.py 73.79% <0.00%> (+54.64%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@ceb8 ceb8 marked this pull request as ready for review April 27, 2022 15:49
@ceb8

ceb8 commented Apr 27, 2022

Copy link
Copy Markdown
Member

@bsipocz This should be ready to go now.

@bsipocz bsipocz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I left a few comments for some more minor cleanups, up to you whether you do them or not in this PR.

Comment thread docs/eso/eso.rst Outdated
Comment thread docs/eso/eso.rst
Comment thread docs/eso/eso.rst Outdated
Comment thread docs/eso/eso.rst
@ceb8 ceb8 force-pushed the eso-doc-cleanup branch from 4fe9c59 to 4519f73 Compare April 29, 2022 15:45
@ceb8 ceb8 merged commit 5ac1834 into astropy:main Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants