added a unit test for checking if KeyError is raised

astropy · bsipocz · Feb 24, 2022 · Jun 23, 2021 · Jun 23, 2021 · Jun 24, 2021
commit d122e3d1e006f258f89a4ea8a6ab0eb756bf8a9c
diff --git a/astroquery/mast/tests/data/mission_incorrect_results.json b/astroquery/mast/tests/data/mission_incorrect_results.json
@@ -0,0 +1,135 @@
+{
+  "messages": [],
+   "info": [
+  {
+    "name": "sci_release_date",
+    "type": "DATETIME"
+  },
+  {
+    "name": "sci_actual_duration",
+    "type": "FLOAT"
+  },
+  {
+    "name": "sci_dec",
+    "type": "FLOAT"
+  },
+  {
+    "name": "sci_pep_id",
+    "type": "INTEGER"
+  },
+  {
+    "name": "sci_spec_1234",
+    "type": "VARCHAR"
+  },
+  {
+    "name": "sci_aper_1234",
+    "type": "VARCHAR"
+  },
+  {
+    "name": "sci_data_set_name",
+    "type": "VARCHAR"
+  },
+  {
+    "name": "sci_preview_name",
+    "type": "VARCHAR"
+  },
+  {
+    "name": "sci_targname",
+    "type": "VARCHAR"
+  },
+  {
+    "name": "sci_instrume",
+    "type": "VARCHAR"
+  },
+  {
+    "name": "search_key",
+    "type": "VARCHAR"
+  },
+  {
+    "name": "sci_central_wavelength",
+    "type": "FLOAT"
+  },
+  {
+    "name": "sci_status",
+    "type": "VARCHAR"
+  },
+  {
+    "name": "sci_stop_time",
+    "type": "DATETIME"
+  },
+  {
+    "name": "scp_scan_type",
+    "type": "VARCHAR"
+  },
+  {
+    "name": "sci_hlsp",
+    "type": "INTEGER"
+  },
+  {
+    "name": "sci_refnum",
+    "type": "INTEGER"
+  },
+  {
+    "name": "sci_start_time",
+    "type": "DATETIME"
+  },
+  {
+    "name": "sci_ra",
+    "type": "FLOAT"
+  }
+],
+  "search_params": {
+    "target": [
+      "40.66963 -0.01328"
+    ],
+    "radius": 3,
+    "radius_units": "arcminutes",
+    "offset": 0,
+    "limit": 5000,
+    "sort_by": [
+      "ang_sep",
+      "sci_targname",
+      "sci_data_set_name"
+    ],
+    "sort_desc": [
+      false,
+      false,
+      false
+    ],
+    "skip_count": false,
+    "select_cols": [
+      "sci_data_set_name",
+      "sci_targname",
+      "sci_ra",
+      "sci_dec",
+      "sci_refnum",
+      "sci_start_time",
+      "sci_stop_time",
+      "sci_actual_duration",
+      "sci_instrume",
+      "sci_aper_1234",
+      "sci_spec_1234",
+      "sci_central_wavelength",
+      "sci_pep_id",
+      "sci_release_date",
+      "sci_preview_name",
+      "scp_scan_type",
+      "sci_hlsp",
+      "sci_status"
+    ],
+    "search_key": [],
+    "user_fields": [],
+    "conditions": [
+      {
+        "sci_obs_type": ""
+      },
+      {
+        "sci_aec": "S"
+      },
+      {
+        "sci_instrume": "STIS,ACS,WFC3,COS,FGS,FOC,FOS,HRS,HSP,NICMOS,WFPC,WFPC2"
+      }
+    ]
+  },
+  "totalResults": 3,
+}
diff --git a/astroquery/mast/tests/test_mast.py b/astroquery/mast/tests/test_mast.py
@@ -116,6 +116,8 @@ def service_mockreturn(self, method="POST", url=None, data=None, timeout=10, use
             filename = data_path(DATA_FILES['z_survey'])
         else:
             filename = data_path(DATA_FILES['z_cutout_fit'])
+    elif use_json and data['radius'] == 5:
+        filename = data_path(DATA_FILES["mission_incorrect_results"])
     elif use_json:
         filename = data_path(DATA_FILES["mission_search_results"])
     content = open(filename, 'rb').read()
@@ -228,6 +230,36 @@ def test_missions_query_criteria_async(patch_post):
     assert isinstance(responses, MockResponse)
 
 
+def test_missions_query_criteria_async_with_missing_results(patch_post):
+    pep_id = {'sci_pep_id': '12556'}
+    obs_type = {'sci_obs_type': "SPECTRUM"}
+    instruments = {'sci_instrume': "stis,acs,wfc3,cos,fos,foc,nicmos,ghrs"}
+    datasets = {'sci_data_set_name': ""}
+    pi_lname = {'sci_pi_last_name': ""}
+    actual_duration = {'sci_actual_duration': ""}
+    spec_1234 = {'sci_spec_1234': ""}
+    release_date = {'sci_release_date': ""}
+    start_time = {'sci_start_time': ""}
+    obs_type = {'sci_obs_type': 'all'}
+    aec = {'sci_aec': 'S'}
+    aperture = {'sci_aper_1234': 'WF3'}
+
+    with pytest.raises(KeyError) as e_info:
+        responses = mast.MastMissions.query_criteria_async(coordinates=regionCoords,
+                                                           radius=5,
+                                                           conditions=[pep_id,
+                                                                       obs_type,
+                                                                       instruments,
+                                                                       datasets,
+                                                                       pi_lname,
+                                                                       spec_1234,
+                                                                       release_date,
+                                                                       start_time,
+                                                                       obs_type,
+                                                                       aec,
+                                                                       aperture])
+
+
 ###################
 # MastClass tests #
 ###################