Skip to content

Fix doc build issues#2226

Merged
bsipocz merged 3 commits into
astropy:mainfrom
bsipocz:docbuild_to_fail_on_warnings
Nov 24, 2021
Merged

Fix doc build issues#2226
bsipocz merged 3 commits into
astropy:mainfrom
bsipocz:docbuild_to_fail_on_warnings

Conversation

@bsipocz

@bsipocz bsipocz commented Nov 23, 2021

Copy link
Copy Markdown
Member

Currently, there are 12 warnings during building the docs, and it's not exactly clear why they don't make the build fail, as -W is being used both in the actions/tox based run, and in rtd.

First I try to make the build fail, then will push all the fix commits.

@codecov

codecov Bot commented Nov 23, 2021

Copy link
Copy Markdown

Codecov Report

Merging #2226 (cb12f86) into main (cbec82e) will increase coverage by 0.15%.
The diff coverage is n/a.

❗ Current head cb12f86 differs from pull request most recent head d46a111. Consider uploading reports for the commit d46a111 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2226      +/-   ##
==========================================
+ Coverage   61.81%   61.96%   +0.15%     
==========================================
  Files         129      129              
  Lines       16295    16297       +2     
==========================================
+ Hits        10072    10099      +27     
+ Misses       6223     6198      -25     
Impacted Files Coverage Δ
astroquery/conftest.py 92.30% <0.00%> (+0.64%) ⬆️
astroquery/alma/core.py 41.35% <0.00%> (+4.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbec82e...d46a111. Read the comment docs.

@bsipocz bsipocz force-pushed the docbuild_to_fail_on_warnings branch from eeb0300 to cb12f86 Compare November 23, 2021 04:12
@bsipocz

bsipocz commented Nov 24, 2021

Copy link
Copy Markdown
Member Author

The warnings are cleared, hopefully, the renaming of the config file will be then enough so it will be picked up by RTD once it's on the main branch.

@bsipocz bsipocz marked this pull request as ready for review November 24, 2021 08:19
@bsipocz bsipocz merged commit daa0581 into astropy:main Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant