Fix for issue #2237: do not cache results that cannot be parsed.#2253
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2253 +/- ##
==========================================
+ Coverage 62.40% 62.44% +0.03%
==========================================
Files 131 131
Lines 16777 16785 +8
==========================================
+ Hits 10470 10481 +11
+ Misses 6307 6304 -3
Continue to review full report at Codecov.
|
keflavich
approved these changes
Dec 21, 2021
Member
|
Thanks @mkelley! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address #2237 by catching result parse errors and removing the corresponding cached file, if applicable. Also add a mock test to that effect.