(Minor fix)eJWST - remove login_gui method from documentation#2257
Merged
Conversation
Contributor
Author
|
Let's see how we can deal with the errors in the tests... |
bsipocz
approved these changes
Jan 11, 2022
bsipocz
left a comment
Member
There was a problem hiding this comment.
No need for changelog entry, otherwise this looks all good to me. I go ahead and merge this not, but will remove the changelog separately, release time at the latest.
Member
|
Thanks, @jespinosaar! CI failure is unrelated and is dealt with separately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @bsipocz,
I have just realized an error in the documentation, as the login_gui method is not included and should be removed. This pull request aims to fix this.
Thanks in advance!