Name convention for ESA modules#2260
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2260 +/- ##
=======================================
Coverage 62.68% 62.68%
=======================================
Files 131 131
Lines 16818 16818
=======================================
Hits 10542 10542
Misses 6276 6276 Continue to review full report at Codecov.
|
bsipocz
approved these changes
Jan 19, 2022
Member
|
Thanks @jespinosaar! The docs page is updated after each commit (practically merge) to the main branch, assuming the RTD build is successful. So, I expect these to land on the page in a few minutes. |
Contributor
Author
|
That was fast! many thanks for your support @bsipocz! I can confirm docs have been updated. See you on next PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @bsipocz ,
This is a small pull request to use the same naming convention for the titles of the modules under astroquery/esa folder. As you can see, the only changes are the titles of JWST, HST and XMM-Newton modules.
Just a question, how often is the documentation (https://astroquery.readthedocs.io/en/latest/) updated? I can see 'astroquery v0.4.6.dev2370' but maybe this is happening when releasing...
Thanks a lot!
Regards,
@jespinosaar