Skip to content

Exclude query parameters from file names is casda.download_file#2308

Merged
bsipocz merged 2 commits into
astropy:mainfrom
jd-au:CASDA-7094-Filename-too-long
Feb 24, 2022
Merged

Exclude query parameters from file names is casda.download_file#2308
bsipocz merged 2 commits into
astropy:mainfrom
jd-au:CASDA-7094-Filename-too-long

Conversation

@jd-au

@jd-au jd-au commented Feb 24, 2022

Copy link
Copy Markdown
Contributor

No description provided.

@bsipocz bsipocz added the casda label Feb 24, 2022
@bsipocz bsipocz added this to the v0.4.6 milestone Feb 24, 2022
@codecov

codecov Bot commented Feb 24, 2022

Copy link
Copy Markdown

Codecov Report

Merging #2308 (08e7ef2) into main (f99e1ba) will increase coverage by 0.12%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2308      +/-   ##
==========================================
+ Coverage   62.84%   62.97%   +0.12%     
==========================================
  Files         130      131       +1     
  Lines       16841    16922      +81     
==========================================
+ Hits        10584    10656      +72     
- Misses       6257     6266       +9     
Impacted Files Coverage Δ
astroquery/casda/core.py 90.39% <88.88%> (+3.18%) ⬆️
astroquery/mast/missions.py 79.45% <0.00%> (ø)
astroquery/mast/services.py 79.56% <0.00%> (+1.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f99e1ba...08e7ef2. Read the comment docs.

@bsipocz

bsipocz commented Feb 24, 2022

Copy link
Copy Markdown
Member

Could you add a changelog entry, please?

@jd-au

jd-au commented Feb 24, 2022

Copy link
Copy Markdown
Contributor Author

Could you add a changelog entry, please?

All done

@bsipocz bsipocz added the bug label Feb 24, 2022
@bsipocz

bsipocz commented Feb 24, 2022

Copy link
Copy Markdown
Member

Thank you @jd-au!

@bsipocz bsipocz merged commit fa423aa into astropy:main Feb 24, 2022
@jd-au jd-au deleted the CASDA-7094-Filename-too-long branch February 24, 2022 05:57
@jd-au

jd-au commented Feb 24, 2022

Copy link
Copy Markdown
Contributor Author

Thanks @bsipocz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants