Make astroquery.mast methods take explicit kwargs #2317
Conversation
|
Before I continue @bsipocz I wanted to verify with you that my first commit is what you had in mind. The mandatory argument is set to explicit while optional arguments are not. I did this because I figure it would get tedious for users to manually input |
glad you asked, see the inline comment. See also https://github.com/astropy/astroquery/pull/2309/files |
|
Would this need a changelog entry? @bsipocz |
|
Yes, a short one, e.g. Also, please squash out the first commit as it's better not to keep those syntax errors in history. |
Sounds good! |
a5d1d1c to
b0a1637
Compare
f4386a2 to
1c04e9b
Compare
Codecov Report
@@ Coverage Diff @@
## main #2317 +/- ##
=======================================
Coverage 62.98% 62.98%
=======================================
Files 131 131
Lines 17059 17059
=======================================
Hits 10745 10745
Misses 6314 6314
Continue to review full report at Codecov.
|
178d803 to
30f6ef9
Compare
|
Thanks @jaymedina! (I confirm that all remote and docs tests pass, too. Though they take a long time (35mins), so we may want to think about how to cut back on them, whether that's possible without sacrificing coverage). |
Make methods for the
astroquery.mastservices (Observations, Catalogs, Cutouts) take explicit keyword arguments to avoid hiccups in the API calls that we've seen in the past. Closes #2267.make kwargs explicit: