Skip to content

Fix cross-id for very old data releases#2318

Merged
bsipocz merged 2 commits into
astropy:mainfrom
weaverba137:sdss-cross-id-url
Mar 3, 2022
Merged

Fix cross-id for very old data releases#2318
bsipocz merged 2 commits into
astropy:mainfrom
weaverba137:sdss-cross-id-url

Conversation

@weaverba137

Copy link
Copy Markdown
Member

This PR fixes #2303. I ran the remote-data tests on my laptop and everything seems to work.

@codecov

codecov Bot commented Mar 2, 2022

Copy link
Copy Markdown

Codecov Report

Merging #2318 (cd722b7) into main (2b3d954) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2318      +/-   ##
==========================================
+ Coverage   63.08%   63.10%   +0.01%     
==========================================
  Files         131      131              
  Lines       17005    17040      +35     
==========================================
+ Hits        10728    10753      +25     
- Misses       6277     6287      +10     
Impacted Files Coverage Δ
astroquery/sdss/core.py 85.95% <100.00%> (+0.14%) ⬆️
astroquery/utils/tap/model/modelutils.py 51.85% <0.00%> (-40.75%) ⬇️
astroquery/esa/hubble/core.py 86.12% <0.00%> (+2.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b3d954...cd722b7. Read the comment docs.

@bsipocz bsipocz added this to the v0.4.6 milestone Mar 3, 2022
@bsipocz

bsipocz commented Mar 3, 2022

Copy link
Copy Markdown
Member

Thank you @weaverba137!

@bsipocz bsipocz merged commit 4e35238 into astropy:main Mar 3, 2022
@weaverba137 weaverba137 deleted the sdss-cross-id-url branch July 20, 2022 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SDSS.query_crossid doesn't work for DR<10

2 participants