Deprecate functions from alma.utils#2332
Merged
Merged
Conversation
…re not working anyway due to API incompatibility)
Codecov Report
@@ Coverage Diff @@
## main #2332 +/- ##
==========================================
- Coverage 63.07% 62.95% -0.12%
==========================================
Files 131 131
Lines 17031 17038 +7
==========================================
- Hits 10743 10727 -16
- Misses 6288 6311 +23
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
keflavich
approved these changes
Mar 22, 2022
keflavich
left a comment
Contributor
There was a problem hiding this comment.
Maybe in the changelog, "deprecate broken functions from alma.utils?
Member
Author
|
Haha, I didn't want to overemphasize that these were broken :) (technically the pyregion one is not broken, but one that won't be needed anymore). |
661a3b4 to
18f840b
Compare
18f840b to
b208c6f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to proceed the removals in #2331 with a proper deprecation cycle (even though the functionalities are currently not compatible with the API, so we could just go ahead with #2331 as is)