A number of CADC authentication and doc fixes#2374
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2374 +/- ##
=======================================
Coverage 63.29% 63.29%
=======================================
Files 132 132
Lines 17245 17256 +11
=======================================
+ Hits 10916 10923 +7
- Misses 6329 6333 +4
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
bsipocz
left a comment
There was a problem hiding this comment.
This needs a rebase to get rid of the merge commit. I think that there maybe something off with on your fork as the change to setup.cfg keeps coming back.
Also, please add a changelog.
|
|
||
| .. doctest-skip:: | ||
|
|
||
| >>> from astroquery.cadc import Cadc |
There was a problem hiding this comment.
It would be great to keep a code example in the docs, so I would prefer if it would be fixed rather than just removed.
There was a problem hiding this comment.
You suggest I should added back with the doctest-skip?
There was a problem hiding this comment.
No, I only set it to skip as the example was broken. (Well, we would need a dummy file anyway, but the problem wasn't with the file itself). So if you suggest to temporarily remove it I'm on board with that one, but for the long term I would find it useful to have a working examples and not just the narrative description of how the file upload should work.
There was a problem hiding this comment.
Done. I hope it's the correct way.
Do I need a changelog even if the API and functionality are essentially the same (just added an extra attribute with a default to a method)? |
OK, it's fine not to add one if you don't expect this to be directly used by users. |
|
Thanks @andamian! Version is on pypi. |
datalinkservice (and not only with the tap service)HTTPError)