Skip to content

Bugfix: SBDB query return unit with exponentials#2377

Merged
ceb8 merged 3 commits into
astropy:mainfrom
jianyangli:fix_sbdb_import_unit_error
Apr 27, 2022
Merged

Bugfix: SBDB query return unit with exponentials#2377
ceb8 merged 3 commits into
astropy:mainfrom
jianyangli:fix_sbdb_import_unit_error

Conversation

@jianyangli

@jianyangli jianyangli commented Apr 26, 2022

Copy link
Copy Markdown
Contributor

When SBDB query returns quantities that have units with exponentials, an error is issued because '^' is used to mark exponentials instead of '**' in the unit strings. Issue #2368 . This PR fixes this bug.

@codecov

codecov Bot commented Apr 26, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #2377 (6329863) into main (d53047b) will increase coverage by 0.00%.
The diff coverage is 75.00%.

@@           Coverage Diff           @@
##             main    #2377   +/-   ##
=======================================
  Coverage   63.29%   63.29%           
=======================================
  Files         132      132           
  Lines       17241    17245    +4     
=======================================
+ Hits        10913    10916    +3     
- Misses       6328     6329    +1
Impacted Files Coverage Δ
astroquery/jplsbdb/core.py 78.61% <75.00%> (-0.09%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@bsipocz bsipocz added this to the v0.4.7 milestone Apr 26, 2022
@bsipocz bsipocz linked an issue Apr 26, 2022 that may be closed by this pull request
JPL SBDB query fails when returned properties have complex units with exponential involved #2368
Closed
@bsipocz bsipocz requested a review from mkelley April 26, 2022 18:57
bsipocz
bsipocz approved these changes Apr 26, 2022
View reviewed changes

@bsipocz bsipocz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changelog entry, otherwise, it looks good to me.

I would wait a few days with the merge though to give a chance for Mike to review it, too.

@jianyangli

jianyangli commented Apr 27, 2022

Copy link
Copy Markdown
Contributor Author

I don't understand the failing check. CHANGES.rst was what I changed in the last two commits. Why did astropy-bot complain it's missing? Could someone help?

@bsipocz

bsipocz commented Apr 27, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

@jianyangli - The changelog needs the number of the PR rather than the issue referenced. Don't worry about it, I can fix up the changelog before releasing. apparently I was wrong, it rather looks like a fluke with the changelog bot.

@ceb8 ceb8 merged commit c2bfa20 into astropy:main Apr 27, 2022
@ceb8

ceb8 commented Apr 27, 2022

Copy link
Copy Markdown
Member

Thanks @jianyangli!

@jianyangli jianyangli deleted the fix_sbdb_import_unit_error branch April 27, 2022 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bsipocz bsipocz bsipocz approved these changes

@mkelley mkelley Awaiting requested review from mkelley

Assignees

No one assigned

Labels

bug jplsbdb

Projects

None yet

Milestone

v0.4.7

Development

Successfully merging this pull request may close these issues.

JPL SBDB query fails when returned properties have complex units with exponential involved

3 participants

@jianyangli @bsipocz @ceb8