Adding warning about non-functioning NRAO module#2387
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2387 +/- ##
==========================================
- Coverage 63.29% 62.84% -0.46%
==========================================
Files 132 133 +1
Lines 17256 17270 +14
==========================================
- Hits 10923 10853 -70
- Misses 6333 6417 +84
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
keflavich
approved these changes
May 3, 2022
keflavich
left a comment
Contributor
There was a problem hiding this comment.
just a minor language nitpick; 👍 otherwise
Co-authored-by: Adam Ginsburg <keflavich@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I suggest putting on a 6-months duration for this warning and removing the module after that, unless the updates as per #2316 are done by then.
I don't add a changelog now but also leave off the label, the non-functioning of the module needs to be mentioned if this ends up in a release without the updates PR.