MNT: cleanup deprecations and obsolte checks#2389
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2389 +/- ##
==========================================
- Coverage 63.31% 62.87% -0.44%
==========================================
Files 133 133
Lines 17271 17246 -25
==========================================
- Hits 10935 10844 -91
- Misses 6336 6402 +66
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
andamian
approved these changes
May 3, 2022
andamian
left a comment
There was a problem hiding this comment.
Run the remote tests locally with more privileges as well as doctests and all passed.
|
@bsipocz - thank you for doing this. |
Member
Author
No worries, PRs with negative lines bring me real joy :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PyVO is a required dependency now.
individual tests can be run with either
python setup.py -t testfilename::testfunctionnameor aspytest testfilename -k testfunctionname0.4.0 has been a while ago, deprecations are likely can be removed now