BUG: alma fixes for list of keywords, fixes #2094#2457
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2457 +/- ##
=======================================
Coverage 62.92% 62.92%
=======================================
Files 133 133
Lines 17300 17302 +2
=======================================
+ Hits 10886 10888 +2
Misses 6414 6414
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
|
The failed |
bsipocz
left a comment
There was a problem hiding this comment.
Please add a changelog entry, and maybe remove the last commit that has the goal of re-triggering CI (that unrelated test is somewhat flaky, I'll try to cook up a solution so it will show up less often as a false failure in the future)
|
|
||
|
|
||
| def test_gen_array_sql(): | ||
| common_select = "select * from ivoa.obscore WHERE " |
2aee9f9 to
250adb0
Compare
|
We generally avoid merge commits for the purpose of updating a branch, so I'll be removing that one prior merging the PR. Otherwise, it all looks good. |
|
Apologies. Is that documented somewhere and I missed it? |
|
very good point, it's in the astropy dev docs at a few places, but it's very much hidden into the weeds, so I suppose we better do a section for it in astroquery itself. opened #2462 to keep track of this |
| alma | ||
| ^^^^ | ||
|
|
||
| - Fixed a regression to handle arrays of string input for the ``query`` methods. [#2094] |
There was a problem hiding this comment.
the number in the changelog should point to the number of the PR. I'm fixing this directly. (and this should be pulled into the dev docs highlights, too as it's also one deep in the weeds)
9fe00d2 to
11b1bb8
Compare
|
Tests have passed here already, I've only removed the last merge commit, so I'm going ahead and merge the PR now. Thanks @at88mph! |
ADQL not handling lists of strings properly. Existing
ORlogic was used instead of introducingINclause.fixes #2094