Setting API key for astroquery.astrometry_net#2459
Merged
Conversation
Update docs to include part of one section intended by original author.
Codecov Report
@@ Coverage Diff @@
## main #2459 +/- ##
=======================================
Coverage 62.92% 62.92%
=======================================
Files 133 133
Lines 17300 17300
=======================================
Hits 10886 10886
Misses 6414 6414 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
keflavich
reviewed
Jul 8, 2022
|
|
||
| For more information about `astropy.config`, see: https://docs.astropy.org/en/stable/config/index.html | ||
|
|
||
| TODO: explain how to set config item for api key or how to get it into keyring. |
Contributor
There was a problem hiding this comment.
I tihnk you can remove this TODO with the edits you put in
Contributor
Author
There was a problem hiding this comment.
I had not removed the TODO since they also wanted to include instructions using keyring. I learned to use keyring and will write a simple example.
Contributor
Author
There was a problem hiding this comment.
I've removed TODO and added keyring example with commit 2092aab
keflavich
approved these changes
Jul 8, 2022
bsipocz
approved these changes
Jul 9, 2022
bsipocz
left a comment
Member
There was a problem hiding this comment.
As we don't yet remote-test this file, this looks good as is. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update docs to include part of one section intended by original author.