BUG: fixes issues with aliases for multi star systems#2467
BUG: fixes issues with aliases for multi star systems#2467rickynilsson wants to merge 4 commits into
Conversation
Update fork
…t made method retrieve no aliases for multiple star systems.
Codecov Report
@@ Coverage Diff @@
## main #2467 +/- ##
==========================================
- Coverage 62.92% 62.92% -0.01%
==========================================
Files 133 133
Lines 17302 17302
==========================================
- Hits 10888 10887 -1
- Misses 6414 6415 +1
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
|
@bsipocz - There's a slight decrease in code coverage for this patch, but hopefully that should be okay. |
There was a problem hiding this comment.
I can confirm that the bug from the issue has been fixed, but ideally, we would need some more tests, too that fail on the current master, but will pass with this PR. It could go into as a remote test, e.g. the one-liner from the bug report would be enough.
The PR also needs a rebase to remove the first update commit of the fork.
| - The deprecated methods ``query_planet()`` and ``query_star()`` have been removed. | ||
|
|
||
| - Stability improvements to ``query_aliases()`` that also addresses bug that made | ||
| method retrieve no aliases for multiple star systems. [#2357] |
There was a problem hiding this comment.
fyi: number has to be the PR number rather than the issue
|
This got closed in favour of #2506 |
Stability improvements to
query_aliases()that also addresses bug that made method retrieve no aliases for multiple star systems.fixes #2357