TST: Closing files in tests#2522
Merged
Merged
Conversation
11 tasks
Member
Author
|
I'm inclined to merge this when CI is green without waiting for the remote tests (aka get this in before the cron kicks in rather that waiting forever for them to run locally) |
Codecov Report
@@ Coverage Diff @@
## main #2522 +/- ##
=======================================
Coverage 63.08% 63.08%
=======================================
Files 133 133
Lines 17313 17313
=======================================
Hits 10922 10922
Misses 6391 6391 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This one lets us not ignore the open file warning.