GAIA: The function upload_table in the TapPlus class must not allow table names that contain a dot#2971
Merged
bsipocz merged 3 commits intoMar 18, 2024
Conversation
added 2 commits
March 18, 2024 18:01
…ss does not allow table names that contain a dot
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2971 +/- ##
==========================================
+ Coverage 66.80% 66.81% +0.01%
==========================================
Files 237 237
Lines 18321 18323 +2
==========================================
+ Hits 12239 12243 +4
+ Misses 6082 6080 -2 ☔ View full report in Codecov by Sentry. |
bsipocz
approved these changes
Mar 18, 2024
bsipocz
left a comment
Member
There was a problem hiding this comment.
Looks all good, thank you! I'll move the changelog and the merge.
|
|
||
| - Default Gaia catalog updated to DR3. [#2596] | ||
|
|
||
| - The function upload_table in the TapPlus class does not allow table names that contain a dot. [#2971] |
Member
There was a problem hiding this comment.
this needs to go in the section for the new release. I'll fix it prior merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a table name that contains a dot is used in the function upload_table, the corresponding table in the Gaia ESA Archive cannot be accessed/removed . The following example describes the issue.
The previous commands generated the following table in the archive
A posible solution is to check whether the table name passed to the function upload_table, contains a dot.
cc @esdc-esac-esa-int
Jira: GAIAMNGT-1548