Skip to content

BUG: changing int comparison to fix incompatibility with astropy 6.1#3008

Merged
bsipocz merged 2 commits into
astropy:mainfrom
bsipocz:BUG_cdms_windows_integer
May 13, 2024
Merged

BUG: changing int comparison to fix incompatibility with astropy 6.1#3008
bsipocz merged 2 commits into
astropy:mainfrom
bsipocz:BUG_cdms_windows_integer

Conversation

@bsipocz

@bsipocz bsipocz commented May 9, 2024

Copy link
Copy Markdown
Member

Hopefully this fixes #3006 and the CI

@bsipocz bsipocz added this to the v0.4.8 milestone May 9, 2024
@codecov

codecov Bot commented May 9, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.35%. Comparing base (886817e) to head (462c2da).
Report is 98 commits behind head on main.

❗ Current head 462c2da differs from pull request most recent head b85a49e. Consider uploading reports for the commit b85a49e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3008      +/-   ##
==========================================
+ Coverage   66.83%   67.35%   +0.52%     
==========================================
  Files         237      236       -1     
  Lines       18327    18320       -7     
==========================================
+ Hits        12248    12339      +91     
+ Misses       6079     5981      -98     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bsipocz bsipocz merged commit e35220b into astropy:main May 13, 2024
@bsipocz bsipocz deleted the BUG_cdms_windows_integer branch June 14, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: int dtype comparison goes wrong linelists.cdms on Windows with astropy 6.1

1 participant