Modulate verbosity on download_products() function#3031
Merged
Conversation
bd4057a to
4322fb7
Compare
9ae3c4b to
8e90326
Compare
bsipocz
reviewed
Jun 14, 2024
bsipocz
left a comment
Member
There was a problem hiding this comment.
This looks good, however, I'll go ahead and do a rebase to remove the unrelated changes from one of the commits and well as the merge commit and more recent conflict.
If tests agree afterwords, I'll go ahead and merge.
9194c4f to
a5189c6
Compare
bsipocz
approved these changes
Jun 14, 2024
Member
|
Thanks @snbianco! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3029
Adds a
verboseparameter to relevant functions so that ifverbose = False, no progress is output.