Bugfix for pagesize and page parameters in catalogs.query_criteria()#3065
Merged
Conversation
bsipocz
requested changes
Jul 10, 2024
bsipocz
left a comment
Member
There was a problem hiding this comment.
Renaming an argument should be done with the deprecation decorator. Could you please add it? There are a couple of examples for it peppered through the modules.
|
|
||
| @class_or_instance | ||
| def service_request_async(self, service, params, page_size=None, page=None, use_json=False, **kwargs): | ||
| def service_request_async(self, service, params, pagesize=None, page=None, use_json=False, **kwargs): |
Member
There was a problem hiding this comment.
We should use a deprecation rename argument for this
syntax fix swap order of decorators
e1be3fe to
126ea05
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix bug so that the
pagesizeandpageparameters work properly forCatalogs.query_criteria().Also added to unit test cases to check that these are working properly.