DEP: refactored out runtime dependency on setuptools#3071
Merged
Conversation
|
Hello @neutrinoceros! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2024-07-19 16:06:35 UTC |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3071 +/- ##
==========================================
- Coverage 67.55% 67.44% -0.11%
==========================================
Files 233 233
Lines 18327 18370 +43
==========================================
+ Hits 12380 12390 +10
- Misses 5947 5980 +33 ☔ View full report in Codecov by Sentry. |
a8b0556 to
99f1d96
Compare
678adc5 to
01be4bd
Compare
keflavich
approved these changes
Jul 22, 2024
Member
|
Thanks @neutrinoceros ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context:
pkg_resources, which is part ofsetuptools, is de facto a runtime dependency ofastroquerypkg_resourcesis also deprecated as an API (see https://setuptools.pypa.io/en/latest/pkg_resources.html)I followed the upstream migration guide here.