Reduced download volume for ESASky JWST tests#3081
Merged
Conversation
|
Hello @imbasimba! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2024-08-09 17:16:51 UTC |
bsipocz
approved these changes
Aug 9, 2024
bsipocz
left a comment
Member
There was a problem hiding this comment.
Changes here looks good. Thanks!
I'll however remove the changelog entry as a rule of thumb we only do those for user facing changes.
Also, I see a few remote test failures, but all of those are unrelated to these specific changes, and thus are better suited for a follow-up PR.
cb820b0 to
65fc1af
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discovered in #3043, JWST has released hundreds of new images in the area we previously used to test the JWST download functionality. I've now changed the tests to download JWST images from an area that currently only has a few observations.