Skip to content

MAINT: adding Python 3.13 to CI#3088

Merged
bsipocz merged 2 commits into
astropy:mainfrom
bsipocz:MAINT_py313
Aug 27, 2024
Merged

MAINT: adding Python 3.13 to CI#3088
bsipocz merged 2 commits into
astropy:mainfrom
bsipocz:MAINT_py313

Conversation

@bsipocz

@bsipocz bsipocz commented Aug 27, 2024

Copy link
Copy Markdown
Member

If we're compatible out of the box then no changelog entry will be needed...

(locally I see one doctesting whitespace issue, it may actually be an upstream doctestplus issue)

@pllim

pllim commented Aug 27, 2024

Copy link
Copy Markdown
Member

I think the whitespace problem is from Python 3.13 itself. According to https://docs.python.org/3.13/whatsnew/3.13.html, "The compiler now strips common leading whitespace from every line in a docstring."

Is there a reason why you must keep the leading whitespace? If not, would be much simpler to adjust the test for Python 3.13 and later. FYI.

@bsipocz

bsipocz commented Aug 27, 2024

Copy link
Copy Markdown
Member Author

A good to know, thanks, I'll change the test then.

@bsipocz

bsipocz commented Aug 27, 2024

Copy link
Copy Markdown
Member Author

This now has a pragmatic workaround for python/cpython#81283

Comment thread tox.ini
@bsipocz bsipocz merged commit 01c4d29 into astropy:main Aug 27, 2024
@bsipocz bsipocz deleted the MAINT_py313 branch August 29, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants