Reduce running time for MAST doctests#3122
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3122 +/- ##
=======================================
Coverage 67.49% 67.49%
=======================================
Files 233 233
Lines 18420 18420
=======================================
Hits 12433 12433
Misses 5987 5987 ☔ View full report in Codecov by Sentry. |
Contributor
Author
bsipocz
approved these changes
Oct 23, 2024
bsipocz
left a comment
Member
There was a problem hiding this comment.
These look good, thanks for making the rearrangements to make these faster.
Member
|
@snbianco - do I need to wait for sign-off from @dr-rodriguez or @astrojimig when you CC them, or that is more of a FYI shout out to them? |
|
Sam let us know during our standup about this change so this is more of an FYI for us. Thanks! |
Member
|
Thanks Sam! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adjusted some of the queries in MAST documentation to reduce the running time of the doctests. Reduced from ~9.5 minutes to ~3 minutes.
I also reformatted some of the queries to be more readable and updated outputs.