feat: add query_hierarchy#3175
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3175 +/- ##
=======================================
Coverage ? 67.72%
=======================================
Files ? 229
Lines ? 18388
Branches ? 0
=======================================
Hits ? 12453
Misses ? 5935
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
keflavich
approved these changes
Jan 14, 2025
keflavich
left a comment
Contributor
There was a problem hiding this comment.
This looks great! I read through the code and docs, and it looks solid. This is a neat addition!
6b95d17 to
4892030
Compare
Member
Author
|
Thanks! |
4892030 to
db80653
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello astroquery maintainers 🙂 !
In the former API, we had two fields
membershipandlink_bibcodethat would hint whether the object had parents. I did not replace those in the rewrite from #2954 as I didn't find them easy to use, and they did not have a direct equivalent in the relational schema.This PR, adds a new query method
query_hierarchyto replace them. The behavior is based on what people can see on the webpages in the hierarchy section. You can either ask for parents, children, or siblings of the object.Ex on NGC4038's page:
The two fields from before (
membershipandlink_bibcode) are only returned if the users ask for them with the argumentdetailed_hierarchy. This is toggled off by default as it has a tendency of duplicating the results a lot (see the example in the new documentation section).