Skip to content

ENH: IRSA: adding servicetype to list_collections#3200

Merged
bsipocz merged 4 commits into
astropy:mainfrom
bsipocz:ENH_irsa_collection_kwarg
Feb 12, 2025
Merged

ENH: IRSA: adding servicetype to list_collections#3200
bsipocz merged 4 commits into
astropy:mainfrom
bsipocz:ENH_irsa_collection_kwarg

Conversation

@bsipocz

@bsipocz bsipocz commented Feb 3, 2025

Copy link
Copy Markdown
Member

We have cached two collection listing queries to help separating out image vs spectral services. This doesn't have to wait until all the issues are sorted upstream for the SSA PR.

closes #3077

@bsipocz bsipocz added this to the v0.4.10 milestone Feb 3, 2025
@bsipocz bsipocz requested a review from keflavich February 3, 2025 22:31
@codecov

codecov Bot commented Feb 3, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 11.11111% with 8 lines in your changes missing coverage. Please review.

Project coverage is 68.32%. Comparing base (0fb73cd) to head (90a44d5).
Report is 324 commits behind head on main.

Files with missing lines Patch % Lines
astroquery/ipac/irsa/core.py 11.11% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3200      +/-   ##
==========================================
- Coverage   68.34%   68.32%   -0.03%     
==========================================
  Files         231      231              
  Lines       19190    19197       +7     
==========================================
  Hits        13116    13116              
- Misses       6074     6081       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bsipocz bsipocz force-pushed the ENH_irsa_collection_kwarg branch from a2e9b04 to 90a44d5 Compare February 12, 2025 05:14
@bsipocz bsipocz merged commit e58ae49 into astropy:main Feb 12, 2025
@bsipocz bsipocz deleted the ENH_irsa_collection_kwarg branch February 12, 2025 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

API discussion for list_collections

1 participant